marco/IsoMmo
Watch
1
0
Fork
You've already forked IsoMmo
 0
Code Issues 42 Pull requests 6 Projects 1 Releases 6 Packages 2 Wiki Activity Actions

chore(analyzers): bump SonarAnalyzer.CSharp to 10.30.0.144632 #176

Closed
panda wants to merge 2 commits from chore/sonaranalyzer-10.30 into main
pull from: chore/sonaranalyzer-10.30
merge into: marco:main
Conversation 2 Commits 2 Files changed 11 +24 -20
panda commented 2026-07-24 01:00:28 +02:00
Collaborator
Copy link

Summary

Renovate's #173 bumped SonarAnalyzer.CSharp 10.29.0.143774 → 10.30.0.144632 but left CI red: the newer analyzer tightens S8969 (redundant null-forgiving !) and adds S8949 (forward a CancellationToken), and with TreatWarningsAsErrors those fail the build. This is the deliberate analyzer ratchet the repo documents (Directory.Build.props: "Bump these DELIBERATELY … addressing new findings in that same change") — the version bump plus the fixes, in one change. Supersedes #173 (close it in favour of this).

What changed

  • Directory.Build.props: SonarAnalyzer pin → 10.30.0.144632.
  • S8969 — 15 genuine redundant ! removed where the compiler already proves non-null (after Assert.NotNull(...) etc.), across test files.
  • S8969 — 2 false positives on TryXxx pass-throughs (AssetPack.TryGet, GameConnection.TryDequeue) where the ! was actually suppressing a real CS8601. Fixed idiomatically with [MaybeNullWhen(false)] out … (mirroring Dictionary.TryGetValue), so both the compiler and Sonar are satisfied — no suppression.
  • S8949 — 1: Task.Run(ReceiveLoopAsync) → Task.Run(ReceiveLoopAsync, CancellationToken.None) (fire-and-forget; the receive loop already handles its own cancellation via _cts.Token, so an explicit opt-out at the scheduling call is the honest choice and avoids an unobserved cancellation on the discarded task).

How it was tested

  • Whole solution builds with 0 warnings under SonarAnalyzer 10.30.0.144632 (TreatWarningsAsErrors).
  • dotnet test IsoMmo.slnx — all green.
  • No .editorconfig severity downgrades, no #pragma suppressions added.
## Summary Renovate's #173 bumped **SonarAnalyzer.CSharp `10.29.0.143774` → `10.30.0.144632`** but left CI red: the newer analyzer tightens **S8969** (redundant null-forgiving `!`) and adds **S8949** (forward a `CancellationToken`), and with `TreatWarningsAsErrors` those fail the build. This is the deliberate analyzer **ratchet** the repo documents (`Directory.Build.props`: *"Bump these DELIBERATELY … addressing new findings in that same change"*) — the version bump **plus** the fixes, in one change. **Supersedes #173** (close it in favour of this). ## What changed - `Directory.Build.props`: SonarAnalyzer pin → `10.30.0.144632`. - **S8969 — 15 genuine** redundant `!` removed where the compiler already proves non-null (after `Assert.NotNull(...)` etc.), across test files. - **S8969 — 2 false positives** on `TryXxx` pass-throughs (`AssetPack.TryGet`, `GameConnection.TryDequeue`) where the `!` was actually suppressing a real `CS8601`. Fixed idiomatically with `[MaybeNullWhen(false)] out …` (mirroring `Dictionary.TryGetValue`), so **both** the compiler and Sonar are satisfied — no suppression. - **S8949 — 1**: `Task.Run(ReceiveLoopAsync)` → `Task.Run(ReceiveLoopAsync, CancellationToken.None)` (fire-and-forget; the receive loop already handles its own cancellation via `_cts.Token`, so an explicit opt-out at the scheduling call is the honest choice and avoids an unobserved cancellation on the discarded task). ## How it was tested - Whole solution builds with **0 warnings** under SonarAnalyzer `10.30.0.144632` (`TreatWarningsAsErrors`). - `dotnet test IsoMmo.slnx` — all green. - No `.editorconfig` severity downgrades, no `#pragma` suppressions added.
chore(analyzers): bump SonarAnalyzer.CSharp to 10.30.0.144632 and fix new findings
All checks were successful
ci / Lint & Test (pull_request) Successful in 2m11s
Details
14e0b62b65
Merge branch 'main' into chore/sonaranalyzer-10.30
Some checks failed
ci / Lua content lint (pull_request) Successful in 44s
Details
ci / Lint & Test (pull_request) Failing after 6m3s
Details
18f8d3b7c7
panda commented 2026-08-02 00:55:41 +02:00
Author
Collaborator
Copy link

doppione

doppione
panda closed this pull request 2026-08-02 00:55:41 +02:00
panda commented 2026-08-02 01:06:04 +02:00
Author
Collaborator
Copy link

Superseded by #220 (SonarAnalyzer 10.31, the newer bump — rebased on main with the new 10.31 findings fixed, closes #164). Closing this older 10.30 bump.

Superseded by #220 (SonarAnalyzer **10.31**, the newer bump — rebased on main with the new 10.31 findings fixed, closes #164). Closing this older 10.30 bump.
Some checks failed
ci / Lua content lint (pull_request) Successful in 44s
Details
ci / Lint & Test (pull_request) Failing after 6m3s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
alpha:wave-0
Alpha — de-risk, do first

  
alpha:wave-1
Alpha — foundations

  
alpha:wave-2
Alpha — features

  
alpha:wave-3
Alpha — refine & stabilize

  
area:assets
Art, sound, the assets.isoa pack and its tools

  
area:combat
Combat system, weapons, balance

  
area:ecology
Natural nodes, harvesting, spawners

  
area:infra
CI, analyzers, dependencies, performance, ops

  
area:render
Client rendering: terrain mesh, shading, sprites, cutaway

  
area:scripting
Lua content scripting host and API

  
area:ui
Client UI, HUD, input, targeting

  
area:world
World model, map format, editor, topology

  
enhancement
New feature or improvement

  
epic
Milestone-level roadmap epic

  
migration
Platform or framework migration

  
post-alpha
Explicitly out of the alpha scope

  
roadmap
Roadmap tracker

  
tech-debt
Accepted debt to revisit

  
type:bug
Something is wrong and reproducible

  
type:chore
Housekeeping: no behaviour change

  
type:design
Design to agree before any implementation

No labels
alpha:wave-0
alpha:wave-1
alpha:wave-2
alpha:wave-3
area:assets
area:combat
area:ecology
area:infra
area:render
area:scripting
area:ui
area:world
enhancement
epic
migration
post-alpha
roadmap
tech-debt
type:bug
type:chore
type:design
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
marco/IsoMmo!176
No description provided.