Migrate remaining freeform SystemMessage (GM feedback, targeting) to the string catalog #73

New issue

Closed

opened 2026-07-19 08:23:52 +02:00 by marco · 0 comments

marco commented

2026-07-19 08:23:52 +02:00

Owner

The rule (CLAUDE.md): all user-facing text goes through the string catalog (SystemMessageId + SystemNotice / SystemMessageCatalog), never loose literals.

#72 migrated the gameplay cues (spell + skill gain). This tracks migrating the remaining freeform SystemMessage(string) so no loose user-facing string remains:

GM command feedback (SpawnCommand, TeleportCommand, KillCommand, ResurrectCommand, CommandRegistry, SaveCommand) — usage strings, "Spawned …", "Cannot spawn there", "Unknown command", "You are not allowed to do that", etc. Many are dynamic → SystemMessageId + args.
Targeting errors (TargetValidator returns strings: "Out of range", "No line of sight", "Invalid target") — these already have catalog ids; make TargetValidator return a SystemMessageId (or map at the send site) and send SystemNotice.
"Target cancelled." in the handler.

Definition of Done

No new SystemMessage(...) with a user-facing literal remains; all cues are SystemNotice(id, args).
TargetValidator reports failures as SystemMessageId, reused by both GM targeting and (already) the spell path where they overlap.
The catalog covers every id (test-enforced, as today).

The rule (CLAUDE.md): **all user-facing text goes through the string catalog** (`SystemMessageId` + `SystemNotice` / `SystemMessageCatalog`), never loose literals. #72 migrated the gameplay cues (spell + skill gain). This tracks migrating the **remaining freeform `SystemMessage(string)`** so no loose user-facing string remains: - **GM command feedback** (`SpawnCommand`, `TeleportCommand`, `KillCommand`, `ResurrectCommand`, `CommandRegistry`, `SaveCommand`) — usage strings, "Spawned …", "Cannot spawn there", "Unknown command", "You are not allowed to do that", etc. Many are dynamic → `SystemMessageId` + args. - **Targeting errors** (`TargetValidator` returns strings: "Out of range", "No line of sight", "Invalid target") — these already have catalog ids; make `TargetValidator` return a `SystemMessageId` (or map at the send site) and send `SystemNotice`. - "Target cancelled." in the handler. ## Definition of Done - No `new SystemMessage(...)` with a user-facing literal remains; all cues are `SystemNotice(id, args)`. - `TargetValidator` reports failures as `SystemMessageId`, reused by both GM targeting and (already) the spell path where they overlap. - The catalog covers every id (test-enforced, as today).

marco referenced this issue

2026-07-20 18:37:32 +02:00

Alpha — epic: PvP arena for friends #107

marco added the

post-alpha

label

2026-07-20 18:42:07 +02:00

marco referenced this issue from a commit

2026-07-22 07:06:25 +02:00

refactor: migrate GM + targeting feedback to the string catalog (#73)

marco referenced this issue from a pull request that will close it,

2026-07-22 07:06:44 +02:00