feat(movement): run/walk gaits — run by default, hold Shift to walk #180

Merged

panda merged 4 commits from feat/run-walk into main 2026-08-02 00:20:56 +02:00

Conversation 3 Commits 4 Files changed 25 +450 -67

panda commented 2026-07-24 12:43:34 +02:00

Collaborator

Copy link

Summary

Splits the single movement speed into two gaits: a faster run (the default) and a slower, deliberate walk (hold Shift). Movement stays server-authoritative — the client sends the gait as an intent and the server picks the per-step cooldown and enforces it as a floor, so a modified client cannot outrun the run cadence. Implements #177 (design + Invariants Check on the issue). Stamina is deliberately not part of this MVP — tracked in #178.

Reviewed with critical-design-review before any code; the agreed Invariants Check and Verification plan live on #177.

What changed

• Wire — MoveRequest(Direction, Running); PlayerState/PlayerMoved carry Running so observers glide + animate the right gait. ProtocolVersion.Current 11 → 12 in the same change.
• Server — two GameOptions: MoveCooldownTicks (walk, now 3 ≈ 300 ms — a touch slower than before) and RunCooldownTicks (1 ≈ 100 ms). MovementSystem keeps the pending intent's gait and gates the step on the matching cooldown; PlayerMobile.Running is the entity's current gait (transient, never serialized) and teleport/resurrect resets it.
• Client — run by default, hold Shift to walk. The move intent is sent at the run cadence and the server paces the steps, so a walking player never under-sends. Mobile glides for a gait-dependent duration and Player plays the run cycle while running.
• Art — extracted the real UO human/run_0..4 (body 400, action group 2) into the pack. To avoid regenerating every asset from whichever client is mounted, this adds a surgical extractor command human-anim <client> <action> <name> [fps] [pack-path] that patches one animation into the existing pack in place; pack also learned the run action for future full rebuilds. (UO art remains a temporary placeholder, to be redone with original art.)
• Harness — move <dir> [run] / goto <x> <y> [run], with the step pacing following the gait so a timed goto reflects real walk vs run speed (docs/debug-harness.md updated).

How it was tested

• Unit (World) — RunWalkTests: a run step applies in fewer ticks than a walk step; a client spamming the run intent cannot beat the run cooldown; the moved state carries the applied gait; a walk step leaves it false. Client.Core — GaitTimingTests (run glides quicker, run fallback speeds the leg cycle); HumanArtLayoutTests extended for the run_* names.
• Whole solution builds 0 warnings; all tests green (7/7 projects).
• Timed in-game (debug harness, fresh DB, same 10-tile path): walk 3.35 s vs run 1.21 s → run is 2.77× faster (≈335 ms/tile vs ≈121 ms/tile, matching the 3-tick and 1-tick cadences).

Screenshots

Mid-stride, walk vs run — the run row is the real UO run cycle (body pitched forward, arms pumping, extended stride), clearly distinct from the upright walk.

Run pose in world (first frame is walking for reference):

Notes / follow-ups

• MoveCooldownTicks is also the creature chase cadence, so creatures now chase at the walk speed (3 ticks) and a running player can outrun them. That's an acceptable MVP consequence (and arguably right — you can sprint away), but if you'd rather creatures kept pace they need their own tunable; say the word and I'll split it.
• Stamina (running should cost something) is #178.

## Summary Splits the single movement speed into two **gaits**: a faster **run** (the default) and a slower, deliberate **walk** (hold **Shift**). Movement stays server-authoritative — the client sends the gait as an *intent* and the server picks the per-step cooldown and enforces it as a floor, so a modified client cannot outrun the run cadence. Implements #177 (design + Invariants Check on the issue). Stamina is deliberately **not** part of this MVP — tracked in #178. Reviewed with `critical-design-review` before any code; the agreed Invariants Check and Verification plan live on #177. ## What changed - **Wire** — `MoveRequest(Direction, Running)`; `PlayerState`/`PlayerMoved` carry `Running` so observers glide + animate the right gait. `ProtocolVersion.Current` 11 → **12** in the same change. - **Server** — two `GameOptions`: `MoveCooldownTicks` (walk, now **3** ≈ 300 ms — a touch slower than before) and `RunCooldownTicks` (**1** ≈ 100 ms). `MovementSystem` keeps the pending intent's gait and gates the step on the matching cooldown; `PlayerMobile.Running` is the entity's current gait (transient, never serialized) and teleport/resurrect resets it. - **Client** — run by default, **hold Shift to walk**. The move intent is sent at the run cadence and the *server* paces the steps, so a walking player never under-sends. `Mobile` glides for a gait-dependent duration and `Player` plays the run cycle while running. - **Art** — extracted the real UO **`human/run_0..4`** (body 400, action group 2) into the pack. To avoid regenerating every asset from whichever client is mounted, this adds a surgical extractor command **`human-anim <client> <action> <name> [fps] [pack-path]`** that patches one animation into the existing pack in place; `pack` also learned the `run` action for future full rebuilds. (UO art remains a temporary placeholder, to be redone with original art.) - **Harness** — `move <dir> [run]` / `goto <x> <y> [run]`, with the step pacing following the gait so a timed `goto` reflects real walk vs run speed (`docs/debug-harness.md` updated). ## How it was tested - **Unit (`World`)** — `RunWalkTests`: a run step applies in fewer ticks than a walk step; a client spamming the run intent **cannot** beat the run cooldown; the moved state carries the applied gait; a walk step leaves it false. **Client.Core** — `GaitTimingTests` (run glides quicker, run fallback speeds the leg cycle); `HumanArtLayoutTests` extended for the `run_*` names. - **Whole solution builds 0 warnings; all tests green** (7/7 projects). - **Timed in-game** (debug harness, fresh DB, same 10-tile path): **walk 3.35 s vs run 1.21 s → run is 2.77× faster** (≈335 ms/tile vs ≈121 ms/tile, matching the 3-tick and 1-tick cadences). ### Screenshots **Mid-stride, walk vs run** — the run row is the real UO run cycle (body pitched forward, arms pumping, extended stride), clearly distinct from the upright walk.  **Run pose in world** (first frame is walking for reference):  ## Notes / follow-ups - `MoveCooldownTicks` is also the **creature chase** cadence, so creatures now chase at the walk speed (3 ticks) and a running player can outrun them. That's an acceptable MVP consequence (and arguably right — you *can* sprint away), but if you'd rather creatures kept pace they need their own tunable; say the word and I'll split it. - Stamina (running should cost something) is **#178**.

panda added 1 commit 2026-07-24 12:43:34 +02:00

feat(movement): run/walk gaits — run by default, hold Shift to walk (#177) 053fe3437f

panda referenced this pull request 2026-07-24 12:43:35 +02:00

feat: player run/walk gaits (run by default, hold Shift to walk) #177

panda added 1 commit 2026-07-24 12:55:07 +02:00

fix(client): overlays keep pace with the run cycle (hair/beard/gear no longer detach) 542d945605

panda commented 2026-07-24 12:57:51 +02:00

Author

Collaborator

Copy link

Follow-up fix: overlays detaching while running

Reported after the first pass: the hair "chased" the character when running. Root cause was mine — DriveOverlay only played a layer's animation if (set.Has(anim)), and the overlay art (hair/beard/equip) had no run_* frames, so while the body played the run cycle each overlay was left neither played nor updated: frozen on its last frame, keeping that frame's own anchor, so it visibly drifted off the head.

Fixed properly, two parts:

• Real run frames for every overlay — extracted run_* (action group 2) for all 7 hair styles, 5 beard styles and 3 equip kinds, so each overlay animates its own run cycle in true lockstep with the body (78 run entries in the pack now). The pack command also learned the run action for equip/hair/beard so future full rebuilds include them.
• Robustness — DriveOverlay now falls back to the walk cycle when a layer lacks the body's action instead of freezing (a frozen overlay keeps a stale anchor and drifts). Covers e.g. the two beard styles whose client art only has 4 of the 5 stored facings.

The surgical extractor command was generalised from human-anim to body-anim <client> <body> <action> <name> <prefix> [fps] [pack] so any body/namespace can be patched into the existing pack.

Verified in-game: in the running poses the hair now sits on the head and follows the forward-leaning stride. Build 0 warnings, all tests green, CI green.

### Follow-up fix: overlays detaching while running Reported after the first pass: **the hair "chased" the character when running.** Root cause was mine — `DriveOverlay` only played a layer's animation `if (set.Has(anim))`, and the overlay art (hair/beard/equip) had **no `run_*` frames**, so while the body played the run cycle each overlay was left *neither played nor updated*: frozen on its last frame, keeping that frame's own anchor, so it visibly drifted off the head. Fixed properly, two parts: - **Real run frames for every overlay** — extracted `run_*` (action group 2) for all 7 hair styles, 5 beard styles and 3 equip kinds, so each overlay animates its own run cycle in true lockstep with the body (78 run entries in the pack now). The `pack` command also learned the `run` action for equip/hair/beard so future full rebuilds include them. - **Robustness** — `DriveOverlay` now falls back to the walk cycle when a layer lacks the body's action instead of freezing (a frozen overlay keeps a stale anchor and drifts). Covers e.g. the two beard styles whose client art only has 4 of the 5 stored facings. The surgical extractor command was generalised from `human-anim` to **`body-anim <client> <body> <action> <name> <prefix> [fps] [pack]`** so any body/namespace can be patched into the existing pack. Verified in-game: in the running poses the hair now sits on the head and follows the forward-leaning stride. Build 0 warnings, all tests green, CI green.

panda referenced this pull request 2026-07-24 13:09:38 +02:00

Stamina economy: running drains stamina, fatigue forces walk #178

panda added 1 commit 2026-07-24 14:10:14 +02:00

Merge remote-tracking branch 'origin/main' into feat/run-walk ... 848cb65b15

# Conflicts:
#	client/IsoMmo.Client/Screens/ServerMessageDispatcher.cs
#	client/IsoMmo.Client/assets/assets.isoa
#	src/IsoMmo.GameServer/Gameplay/MovementSystem.cs
#	src/IsoMmo.Shared/Protocol/ProtocolVersion.cs

panda commented 2026-07-24 14:14:40 +02:00

Author

Collaborator

Copy link

Realigned on main after #155 merged

Merged the new main (biome art + map + marsh move-cost) into this branch and resolved all four expected conflicts:

• ProtocolVersion — both branches had claimed 12. Marsh feedback keeps 12 (it landed first, on main); the run/walk gait becomes 13, with both changelog lines preserved.
• MovementSystem — the substantive one: the two gates are now composed rather than either/or. The gait picks the base cadence and the terrain scales it:
  MoveCostTicks(running ? runCooldownTicks : walkCooldownTicks, from, into) — so marsh slows a runner and a walker alike, using the costlier of from/into, and the result is still the floor the server enforces.
• ServerMessageDispatcher — combined: MoveTo(tile, moved.Running) and the marsh step feedback fire on the same PlayerMoved.
• assets.isoa — rebuilt rather than picked: took main's pack (biome land art, dual-grid masks, marsh ripple), re-applied own-art, then re-extracted the run animations. The merged pack carries 78 run entries (human + 7 hair + 5 beard + 3 equip), 50 land tiles, 16 masks and the ripple.

Also added the composition test the owner asked for — marsh × gait: a run step through marsh is slower than one on grass, yet still quicker than walking the marsh (you can sprint the bog, it just costs you).

Whole solution builds 0 warnings; all tests green (7/7 projects, 513 tests, marsh and run/walk suites side by side); CI green; branch mergeable.

### Realigned on `main` after #155 merged Merged the new `main` (biome art + map + marsh move-cost) into this branch and resolved all four expected conflicts: - **`ProtocolVersion`** — both branches had claimed 12. Marsh feedback keeps 12 (it landed first, on `main`); the run/walk gait becomes **13**, with both changelog lines preserved. - **`MovementSystem`** — the substantive one: the two gates are now **composed** rather than either/or. The gait picks the base cadence and the terrain scales it: `MoveCostTicks(running ? runCooldownTicks : walkCooldownTicks, from, into)` — so marsh slows a runner and a walker alike, using the costlier of from/into, and the result is still the floor the server enforces. - **`ServerMessageDispatcher`** — combined: `MoveTo(tile, moved.Running)` *and* the marsh step feedback fire on the same `PlayerMoved`. - **`assets.isoa`** — rebuilt rather than picked: took `main`'s pack (biome land art, dual-grid masks, marsh ripple), re-applied `own-art`, then re-extracted the run animations. The merged pack carries **78 run entries** (human + 7 hair + 5 beard + 3 equip), 50 land tiles, 16 masks and the ripple. Also added the composition test the owner asked for — **marsh × gait**: a run step through marsh is slower than one on grass, yet still quicker than walking the marsh (you *can* sprint the bog, it just costs you). Whole solution builds 0 warnings; all tests green (7/7 projects, 513 tests, marsh and run/walk suites side by side); CI green; branch mergeable.

panda referenced this pull request 2026-07-24 14:39:12 +02:00

feat(gameplay): stamina — running drains it, exhaustion forces a walk (#178) #185

panda added 1 commit 2026-08-02 00:14:57 +02:00

Merge origin/main into feat/run-walk: reconcile run/walk gait with terrain-Z, chunked world, inventory (protocol 18) a1a5780457

panda commented 2026-08-02 00:15:55 +02:00

Author

Collaborator

Copy link

Updated to current main (was 43 commits behind → not mergeable). Conflicts resolved:

• ProtocolVersion → 18 (the run/walk gait stacks on top of scripting/vitals/inventory 13–17).
• MovementSystem / World — keeps both gait cadences (walk + run) and main's step-height / terrain-cost gate: MoveCostTicks(baseCooldown,...) + CanStep(..., maxStepZ); ctor is now MovementSystem(map, walkCooldownTicks, runCooldownTicks, maxStepZ).
• Mobile (client) — preserves main's flat-foot/ground-Z heightfield split (glide interpolates both) and layers the gait (Running, per-gait glide duration).
• assets.isoa — took main's current pack (all terrain/biome art). Run uses the sped-up walk-frame fallback (GaitTiming.FallbackFpsScale, which the feature was designed for); re-baking the real run frames into the current pack is a follow-up.

Gates green in a worktree off current main: whole solution builds with 0 warnings, 763 tests pass (incl. RunWalkTests + the terrain-Z suite), CSharpier clean. mergeable is now true.

Updated to current `main` (was 43 commits behind → not mergeable). Conflicts resolved: - **ProtocolVersion** → 18 (the run/walk gait stacks on top of scripting/vitals/inventory 13–17). - **MovementSystem / World** — keeps both gait cadences (walk + run) **and** main's step-height / terrain-cost gate: `MoveCostTicks(baseCooldown,...)` + `CanStep(..., maxStepZ)`; ctor is now `MovementSystem(map, walkCooldownTicks, runCooldownTicks, maxStepZ)`. - **Mobile** (client) — preserves main's flat-foot/ground-Z heightfield split (glide interpolates both) **and** layers the gait (`Running`, per-gait glide duration). - **assets.isoa** — took **main's** current pack (all terrain/biome art). Run uses the sped-up walk-frame fallback (`GaitTiming.FallbackFpsScale`, which the feature was designed for); re-baking the real run frames into the current pack is a follow-up. Gates green in a worktree off current main: whole solution builds with **0 warnings**, **763 tests** pass (incl. `RunWalkTests` + the terrain-Z suite), CSharpier clean. `mergeable` is now true.

panda scheduled this pull request to auto merge when all checks succeed 2026-08-02 00:17:46 +02:00

panda merged commit ddb4469670 into main 2026-08-02 00:20:56 +02:00

panda deleted branch feat/run-walk 2026-08-02 00:20:57 +02:00

panda referenced this pull request from a commit 2026-08-02 00:20:58 +02:00

feat(movement): run/walk gaits — run by default, hold Shift to walk (#180)

panda referenced this pull request 2026-08-02 00:47:14 +02:00

feat: player run/walk gaits (run by default, hold Shift to walk) #177

panda referenced this pull request from a commit 2026-08-02 00:56:44 +02:00

feat(gameplay): stamina — running drains it, exhaustion forces a walk (#178) (#185)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

alpha:wave-0

Alpha — de-risk, do first

  

alpha:wave-1

Alpha — foundations

  

alpha:wave-2

Alpha — features

  

alpha:wave-3

Alpha — refine & stabilize

  

area:assets

Art, sound, the assets.isoa pack and its tools

  

area:combat

Combat system, weapons, balance

  

area:ecology

Natural nodes, harvesting, spawners

  

area:infra

CI, analyzers, dependencies, performance, ops

  

area:render

Client rendering: terrain mesh, shading, sprites, cutaway

  

area:scripting

Lua content scripting host and API

  

area:ui

Client UI, HUD, input, targeting

  

area:world

World model, map format, editor, topology

  

enhancement

New feature or improvement

  

epic

Milestone-level roadmap epic

  

migration

Platform or framework migration

  

post-alpha

Explicitly out of the alpha scope

  

roadmap

Roadmap tracker

  

tech-debt

Accepted debt to revisit

  

type:bug

Something is wrong and reproducible

  

type:chore

Housekeeping: no behaviour change

  

type:design

Design to agree before any implementation

No labels

alpha:wave-0

alpha:wave-1

alpha:wave-2

alpha:wave-3

area:assets

area:combat

area:ecology

area:infra

area:render

area:scripting

area:ui

area:world

enhancement

epic

migration

post-alpha

roadmap

tech-debt

type:bug

type:chore

type:design

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

marco/IsoMmo!180

No description provided.