refactor: standards cleanup (dedup, config, one-type-per-file, dead code) #50

Merged

marco merged 2 commits from chore/standards-batch into main

2026-07-19 00:51:51 +02:00

marco commented

2026-07-19 00:47:05 +02:00

Owner

Stacked on #49 (uses its GridPosition.ChebyshevDistanceTo). Server-side items from the code-review standards batch:

Chebyshev distance deduped onto GridPosition (MobileRegistry/CorpseRegistry/CombatSystem/ItemRegistry/TargetValidator).
PersistenceService interval → GameOptions.PersistenceIntervalSeconds.
Split WanderAi/MeleeAi into their own files (one-type-per-file; AI seam types stay grouped).
Removed dead code (ReadPeopleAnimation, AnimFrame.PixelAt).
ConnectionManager → primary constructor.

Green: GameServer 113, Shared 50, 0 warnings, csharpier clean. Client/tools micro-nits from the review (AssetPack record split, HumanArtSet rename, Vector2/ARGB dedup, client-config single source, remaining primary ctors, StartsWith/using tidy) are tracked separately to keep this PR focused.

**Stacked on #49** (uses its `GridPosition.ChebyshevDistanceTo`). Server-side items from the code-review standards batch: - Chebyshev distance deduped onto `GridPosition` (MobileRegistry/CorpseRegistry/CombatSystem/ItemRegistry/TargetValidator). - `PersistenceService` interval → `GameOptions.PersistenceIntervalSeconds`. - Split `WanderAi`/`MeleeAi` into their own files (one-type-per-file; AI seam types stay grouped). - Removed dead code (`ReadPeopleAnimation`, `AnimFrame.PixelAt`). - `ConnectionManager` → primary constructor. Green: GameServer 113, Shared 50, 0 warnings, csharpier clean. Client/tools micro-nits from the review (AssetPack record split, HumanArtSet rename, Vector2/ARGB dedup, client-config single source, remaining primary ctors, StartsWith/using tidy) are tracked separately to keep this PR focused.

marco added 1 commit

2026-07-19 00:47:05 +02:00

refactor: standards cleanup (dedup, config, one-type-per-file, dead code)

ci / Lint & Test (pull_request) Successful in 1m36s

Details

474b87c1fc

- Chebyshev distance deduped onto GridPosition.ChebyshevDistanceTo across
  MobileRegistry/CorpseRegistry/CombatSystem/ItemRegistry/TargetValidator.
- PersistenceService interval -> GameOptions.PersistenceIntervalSeconds (config
  in one place, like every other tunable).
- Split WanderAi/MeleeAi out of BaseAi.cs (one type per file; the AI seam types
  stay grouped).
- Removed dead code (AnimMulReader.ReadPeopleAnimation, AnimFrame.PixelAt).
- ConnectionManager -> primary constructor.

marco changed target branch from chore/world-thin-facade to main

2026-07-19 00:51:33 +02:00

marco merged commit 0733acee48 into main

2026-07-19 00:51:51 +02:00

marco deleted branch chore/standards-batch

2026-07-19 00:51:51 +02:00

marco referenced this pull request from a commit

2026-07-19 00:51:52 +02:00

refactor: standards cleanup (dedup, config, one-type-per-file, dead code) (#50)